E-point for profile

[abomin]

Hi all!
I`ve try to adapt AFA patch from 5508 to 5601:
#pragma enable old_equal_ff
3CADD4: E6F8A000 FAE000C7
0x40C700: DC49D418860046F120202D1747F22000
0x40C710: 8D04E6F8A000FADCD8ADDC49D4488800
0x40C720: 46F420003DF6DC49D4488A0046F42000
0x40C730: 3DF0E02CE6FE8C000D03E01CE6FE8800
0x40C740: 00E8E6FF0038DC49A92EBD0ABB125C41
0x40C750: F132BB0F7123D7403700B92F08F10DF3
0x40C760: E6F1DB00D7403700B81FDA0D00F8FADC
0x40C770: 3AADDC49A92E00EC27F2300047F20A00
0x40C780: 8D0367F2DF002927CB00
Attention! Undo APS+ALF patch before! (IMHO it`s better to use AFA if will work OK). GoLL@B, test it, plz.

[GoLL@B]

I undo APF, I applied your patch and it works... but when the profil is changing I have vibra 3 times or I hear piip (short part of ringing tone for appointments). It dependents of profile. I`ll check next profiles and I`ll write my suggestions.

[cyperghost]

Does it work with modified version off patch I posted in this thread? I tested it with FAV only and it works perfect. But I didn't tested it with AFA - so it depends on you of testing

___________

I tested it - it's just as you descriped. 1st change is okay, 2nd change isn't applied *arggg*
I hope abomin can fix this

[GoLL@B]

Yes, I tested this...
abomin modified patch from Xinshou for v56 and it works but I have 3 vibra If I use profile quiet, short piip if I use profile normal and nothing when I use profile 1.

Normal - sound on, no vibra
Quiet - no sound, vibra on
Profile 1 - no vibra, no sound

[abomin]

Try another version, but use double dot (.. - two full points, ASCII #2E) instead of double space.

3CADD4: E6F8A000 FAE000C7
0x40C700: DC49D418860046F12E2E2D1747F22000
0x40C710: 8D04E6F8A000FADCD8ADDC49D4488800
0x40C720: 46F42E003DF6DC49D4488A0046F42E00
0x40C730: 3DF0E02CE6FE8C000D03E01CE6FE8800
0x40C740: 00E8E6FF0038DC49A92EBD0ABB125C41
0x40C750: F132BB0F7123D7403700B92F08F10DF3
0x40C760: E6F1DB00D7403700B81FDA0D00F8FADC
0x40C770: 3AADDC49A92E00EC27F2300047F20A00
0x40C780: 8D0367F2DF002927CB00

[GoLL@B]

I have the same problem - vibra and sound but it`s not so nervous for me. I think that it can be...

Very very thanks for help for all

ps. I checked, if we try to run a midlet thanks to AFA and we have profile quiet ( I set no sounds but vibra ) we have 3x vibra too.

[lalo.lerry]

Originally Posted by cyperghost

Version to work with FAV and all other Patches which can call (AFA, GFX, hotkeys)
0x40CBA0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0000D7400D00F6FC8824DAA44A98db00 ; normal
0x40CBB3: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0101D7400D00F6FC8824DAA44A98db00 ; quite
0x40CBC6: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0202D7400D00F6FC8824DAA44A98db00 ; loud
0x40CBD9: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0303D7400D00F6FC8824DAA44A98db00 ; 1
0x40CBEc: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0404D7400D00F6FC8824DAA44A98db00 ; 2
0x40CBFf: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0505D7400D00F6FC8824DAA44A98db00 ; 3
;And use e-points: f.e DAE0A0CB for swap to normal profile.

My friend Cyper,
in this code there are some errors:
- first of all, why you call (DA) setProfile() + rets (DB00)? it's not smaller and cleverer making a absolut jump (FA) to setProfile(), without neading the rets instruction?

-second, you mismatch address counting (strings are 11bytes long):
0x40CBB3: sould be 0x40CBB2
0x40CBC6: sould be 0x40CBC4
0x40CBD9: sould be 0x40CBD6
0x40CBEC: sould be 0x40CBE8
0x40CBFF: sould be 0x40CBFA

and morover, you cannot make a call or jump to an not even offset... phone will crash immediately

Bye

Lalo

[cyperghost]

My friend lalo

in this code there are some errors:

As you know I'm not a patcher and surly there are errors in - but it works.

first of all, why you call (DA) setProfile() + rets (DB00)? it's not smaller and cleverer making a absolut jump (FA) to setProfile(), without neading the rets instruction?

Why not? If don't use return command all lines are cyceld throug. Means if I make call to 'normal' it jumps through 'quite' -> 'loud' -> 'profile 1' -> 'profile 2' -> 'profile 3' and then returns (why?)

So I splitted code in "subroutines" each with it's own return command. I just improved Goll@bs idea of changing profiles with command instructions trustkill posted

-second, you mismatch address counting (strings are 11bytes long):

Indeed I wasted 5 bytes - but it's a 18byte string.

and morover, you cannot make a call or jump to an not even offset... phone will crash immediately

No, phone does not crash. But this surprise was posted in annother reply in this thread by me. I also wondered why phone does not shut off.

But maybe you can help us to make this code smarter? Maybe with message window if profile changes (or accoustic event?)

With best reagrds
cyperghost

_______________

Not 5 byte wasting version posted above

0x40CBA0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0000D7400D00F6FC8824DAA44A98db00 ; normal
0x40CBB2: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0101D7400D00F6FC8824DAA44A98db00 ; quite
0x40CBC4: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0202D7400D00F6FC8824DAA44A98db00 ; loud
0x40CBD6: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0303D7400D00F6FC8824DAA44A98db00 ; 1
0x40CBE8: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0404D7400D00F6FC8824DAA44A98db00 ; 2
0x40CBFA: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0505D7400D00F6FC8824DAA44A98db00 ; 3

;And use e-points: f.e DAE0A0CB for swap to normal profile.

[rc-flitzer]

cyperghost wrote:

Why not? If don't use return command all lines are cyceld throug. Means if I make call to 'normal' it jumps through 'quite' -> 'loud' -> 'profile 1' -> 'profile 2' -> 'profile 3' and then returns (why?)

Maybe you misunderstood lalo. He wanted to give you a way which has the same semantics and saves two bytes for each line.
In your lines you use the commands "Call xyz, return", using the codes "DA......DB00". Now imagine what for a command is executed when your called routine will return? It's "DB00"! So you kind of double-return with your code because the called routine also has a return command.
And lalo's idea is that you just "jump xyz", using "FA......". Then the return command from the "jumped" routine will have the same consequence as your former DB00. ... I don't know how to explain properly, but you just save two bytes.
And it will not run into the other lines. Try it!

About calling odd addresses: it should not work... it if does, well, fine. But does it really what you want?

[cyperghost]

Please explain "odd addresses"
Yes the patch work as it should... we can call adresses and the profile switches to the called one.

I just "analyzed" the patch and saw a calling DA command. Then I started a hexeditor and sfe and looked if there is any DB00 in called routine (and there was one), so I thought why not use return command for jump back?
I'm very thankfull for your advices - really!

So you think I should change
0x40CBA0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0000D7400D00F6FC8824DAA44A98db00

to 0x40CBA0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF E6FC0000D7400D00F6FC8824FAA44A98?

This would save 12 bytes

What's the difference between DA and FA (FA = absolute jump?)? What is CB00 (not DB00 )

Maybe today I outed me as someone who has no knowledge in patching

[rc-flitzer]

Please explain "odd addresses"

Odd is the opposite of even - an odd address is a not even address, ending with an odd number (1,3,5,7,9).

What's the difference between DA and FA (FA = absolute jump?)? What is CB00 (not DB00 )

Right, FA is absolute jump while DA is absolute call. That's why it works and why you save 12 bytes.
DB00 is return from absolute (far) call, CB00 is return from local call. If you need to know more, have a look at the German help files about C166 assembler. They're to find in "Anleitungen" (Guides) on gsm-modding.de

And: you may have less knowledge than lalo or me at the moment, but you have much curiosity that leads to knowledge.

[lalo.lerry]

Originally Posted by cyperghost

No, phone does not crash. But this surprise was posted in annother reply in this thread by me. I also wondered why phone does not shut off.

Are you sure you have tried to call an odd address?
In your old version, this one:

0x40CBA0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0000D7400D00F6FC8824DAA44A98db00 ; normal
0x40CBB3: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0101D7400D00F6FC8824DAA44A98db00 ; quite
0x40CBC6: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0202D7400D00F6FC8824DAA44A98db00 ; loud
0x40CBD9: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0303D7400D00F6FC8824DAA44A98db00 ; 1
0x40CBEc: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0404D7400D00F6FC8824DAA44A98db00 ; 2
0x40CBFf: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFffff E6FC0505D7400D00F6FC8824DAA44A98db00 ; 3

have you really ever tried to call quite/1/3 profiles?

Originally Posted by cyperghost

But maybe you can help us to make this code smarter? Maybe with message window if profile changes (or accoustic event?)

I know how, but... I wish I could!

Originally Posted by rc-flitzer

And: you may have less knowledge than lalo or me at the moment, but you have much curiosity that leads to knowledge.

Right! And certainly he have more TIME!

Bye and good new year to everyone

Lalo

[cyperghost]

have you really ever tried to call quite/1/3 profiles?

No! I just called, normal and profile 2
Bad Day

I know how, but... I wish I could!

This doesn't matter - Thank you again for your help

Right! And certainly he have more TIME!

No, I'm also a student and sometimes temporarily stressed. Assembling is a very time expensive "hobby" so I just learned some basics. But if you know how a programm is structered you can get good results by try and error

Have a happy new year

[trustkill]

Whats the essence of this thread ? WHAT should someone install if he wants to change the profiles via AFA ?

[cyperghost]

He should install this and call EP with AFA

0x40CBA0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF E6FC0000D7400D00F6FC8824FAA44A98; normal
0x40CBB0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF E6FC0101D7400D00F6FC8824FAA44A98; quite
0x40CBC0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF E6FC0202D7400D00F6FC8824FAA44A98; loud
0x40CBD0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF E6FC0303D7400D00F6FC8824FAA44A98; 1
0x40CBE0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF E6FC0404D7400D00F6FC8824FAA44A98; 2
0x40CBF0: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF E6FC0505D7400D00F6FC8824FAA44A98; 3